xfs
[Top] [All Lists]

Re: [PATCH] xfstest: log operations properly to generic/001.full

To: Ming Chen <v.mingchen@xxxxxxxxx>
Subject: Re: [PATCH] xfstest: log operations properly to generic/001.full
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 9 Apr 2014 10:08:09 +1000
Cc: xfs@xxxxxxxxxxx, Erez Zadok <ezk@xxxxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <CAG+wggbx13tnYB=J8q83oK72td2VV=V1Fg=-q3JnZb=5tCgCSQ@xxxxxxxxxxxxxx>
References: <CAG+wggbx13tnYB=J8q83oK72td2VV=V1Fg=-q3JnZb=5tCgCSQ@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sat, Apr 05, 2014 at 01:52:43AM -0400, Ming Chen wrote:
> Part of the operations were written to 001.full from the awk script, while the
> rest were piped to 001.full using tee.  The resultant 001.full did not reflect
> what are really performed.  This makes debugging difficult.
> 
> Signed-off-by: Ming Chen <v.mingchen@xxxxxxxxx>

This patch causes generic/001 to fail because it pushes all the
debug into the output file as well as the generic/001.full file.

diff -u tests/generic/001.out 
/home/dave/src/xfstests-dev/results//generic/001.out.bad
--- tests/generic/001.out       2014-01-20 16:57:33.000000000 +1100
+++ /home/dave/src/xfstests-dev/results//generic/001.out.bad    2014-04-09 
09:58:34.000000000 +1000
@@ -1,9 +1,1189 @@
 QA output created by 001
 cleanup
 setup ....................................
-iter 1 chain ... check ....................................
-iter 2 chain ... check ....................................
-iter 3 chain ... check ....................................
-iter 4 chain ... check ....................................
-iter 5 chain ... check ....................................
+iter 1 chain ... 2320100 sub/e.0
+2320101 sub/g.0
+2320102 sub/m00.0
+2320103 sub/b.0
+2320104 sub/d00.0
+2320105 sub/c.0
+2320106 sub/l00.0
+2320107 sub/c.1
.....

I'm going to drop this patch because it breaks a previously working
test....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>