xfs
[Top] [All Lists]

Re: [PATCH] xfstest: log operations properly to generic/001.full

To: Ming Chen <v.mingchen@xxxxxxxxx>
Subject: Re: [PATCH] xfstest: log operations properly to generic/001.full
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 9 Apr 2014 09:43:54 +1000
Cc: xfs@xxxxxxxxxxx, Erez Zadok <ezk@xxxxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <CAG+wggbx13tnYB=J8q83oK72td2VV=V1Fg=-q3JnZb=5tCgCSQ@xxxxxxxxxxxxxx>
References: <CAG+wggbx13tnYB=J8q83oK72td2VV=V1Fg=-q3JnZb=5tCgCSQ@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sat, Apr 05, 2014 at 01:52:43AM -0400, Ming Chen wrote:
> Part of the operations were written to 001.full from the awk script, while the
> rest were piped to 001.full using tee.  The resultant 001.full did not reflect
> what are really performed.  This makes debugging difficult.
> 
> Signed-off-by: Ming Chen <v.mingchen@xxxxxxxxx>
> ---
>  tests/generic/001 | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/generic/001 b/tests/generic/001
> index 6e5f3dd..e1142ed 100755
> --- a/tests/generic/001
> +++ b/tests/generic/001
> @@ -190,7 +190,7 @@ _mark_iteration()
>  #
>  _chain()
>  {
> -    $AWK_PROG -v full_file=$seqres.full -v verify=$verify <$tmp.config '
> +    $AWK_PROG -v verify=$verify <$tmp.config '
>  BEGIN  { nfile = 0 }
>  /^\#/  { next }
>         { file[nfile] = $1
> @@ -210,7 +210,7 @@ END { srand('$iter')
>                 printf "if [ ! -f %s ]; then echo \"%s missing!\";
> exit; fi\n",file[j],file[j]
>                 printf "if [ -f %s.0 ]; then echo \"%s.0 already
> present!\"; exit; fi\n",file[j],file[j]

Your mailer program has line wrapped the patch and converted all the
tabs to spaces. I've fixed it up this time, but please read the
Documentation/SubmittingPatches file in the kernel tree to learn how
to prevent this from happening in future.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>