xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfsdump: getdents.c: clean up ifdef-hell around sys_getd

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/2] xfsdump: getdents.c: clean up ifdef-hell around sys_getdents
From: Kyle McMartin <kmcmarti@xxxxxxxxxx>
Date: Tue, 8 Apr 2014 09:35:54 -0400
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140408003311.GH27017@dastard>
References: <20140324181907.GF23291@xxxxxxxxxxxxxxxxxxxxxxx> <20140408003311.GH27017@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Apr 08, 2014 at 10:33:11AM +1000, Dave Chinner wrote:
> On Mon, Mar 24, 2014 at 02:19:07PM -0400, Kyle McMartin wrote:
> > Remove the ifdef-hell imported from glibc around getdents64. Everything
> > since 2.4.1 supports things properly and this seems like a sensible
> > clean up, so lets just assume it exists and handle it by falling back
> > if not.
> > 
> > Additionally, if the old getdents syscall doesn't exist, just stub out
> > the actual syscall and return ENOSYS.
> > 
> > ---
> 
> Kyle, these two patches are missing your SOB. I'm going to assume
> you wrote this yourself (given the history, it's a fair bet :)
> and add them in - let me know if then assumption is wrong so I can
> correct it.

That's correct, my apologies for not including it on the submission.

Thanks very much Dave.

--Kyle

<Prev in Thread] Current Thread [Next in Thread>