xfs
[Top] [All Lists]

Re: [PATCH 00/19] xfs: remove a bunch of unused function args

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH 00/19] xfs: remove a bunch of unused function args
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 8 Apr 2014 09:28:46 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1396900746-22201-1-git-send-email-sandeen@xxxxxxxxxx>
References: <1396900746-22201-1-git-send-email-sandeen@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Apr 07, 2014 at 02:58:47PM -0500, Eric Sandeen wrote:
> I did some mindless work during a plane ride.  ;)
> 
> If the granularity of these patches is just too much, I could certainly
> collapse them into fewer, bigger patches, but I figured that this would
> make them super-trivial to review.
> 
> Most have no interesting commit messages aside from the subject, because
> the subject says it all.
> 
> Compile-tested only, TBH.

Looks good, except for the patch I specifically commented on.

FWIW, this sort of cleanup will help reduce some of the register
pressure these code paths have, and that in turn will help reduce
stack usage, so if you can find more...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>