On 3/31/14, 7:09 AM, Brian Foster wrote:
> On Fri, Mar 28, 2014 at 09:01:26PM -0500, Eric Sandeen wrote:
>> Several functions pass a transaction pointer around,
>> but it's never used in those callchains. Remove it.
>> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
>> diff --git a/fs/xfs/xfs_bmap.c b/fs/xfs/xfs_bmap.c
>> index 152543c..b308097 100644
>> --- a/fs/xfs/xfs_bmap.c
>> +++ b/fs/xfs/xfs_bmap.c
>> @@ -1675,7 +1675,6 @@ xfs_bmap_isaeof(
>> - struct xfs_trans *tp,
>> struct xfs_inode *ip,
>> xfs_fileoff_t *last_block,
>> int whichfork)
> Seems Ok to me, but it looks like you could also kill the tp param for
> xfs_bmap_last_extent(). I don't see any callers that don't pass NULL...
Actually I think that'd be a separate change, and not totally obvious
that it's one we should make - I'm (lazily) not sure if someone might
need to pass in a tp to be used in xfs_iread_extents() some time
in the future...