xfs
[Top] [All Lists]

Re: [Lsf] [PATCH] xfstests-bld: Simplify determination of number of CPUs

To: Andy Lutomirski <luto@xxxxxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [Lsf] [PATCH] xfstests-bld: Simplify determination of number of CPUs in build-all
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 03 Apr 2014 15:46:24 -0600
Cc: Theodore Ts'o <tytso@xxxxxxx>, xfs@xxxxxxxxxxx, lsf@xxxxxxxxxxxxxxxxxxxxxxxxxx, Sedat Dilek <sedat.dilek@xxxxxxxxx>, Linux FS Devel <linux-fsdevel@xxxxxxxxxxxxxxx>, Lukáš Czerner <lczerner@xxxxxxxxxx>, "linux-ext4@xxxxxxxxxxxxxxx" <linux-ext4@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <CALCETrVq1DfpyhThajc9FYA7NLWYt9oX4vadCDcqn+d26aALGA@xxxxxxxxxxxxxx>
References: <1395997399-3000-1-git-send-email-sedat.dilek@xxxxxxxxx> <20140328161806.GA31772@xxxxxxxxx> <20140331025148.GF16336@dastard> <20140401023711.GE4911@xxxxxxxxx> <20140401222823.GJ17603@dastard> <20140402142620.GA6901@xxxxxxxxx> <20140403011411.GL16336@dastard> <alpine.LFD.2.00.1404031102310.2124@xxxxxxxxxxxxxxxxxxxxx> <CALCETrU=JWigDSv6ymepS2tjL+EkO98VDC03-RSPuhQVk3yvZA@xxxxxxxxxxxxxx> <20140403173504.GB23737@xxxxxxxxx> <533DB140.8010103@xxxxxxxxxx> <CALCETrVq1DfpyhThajc9FYA7NLWYt9oX4vadCDcqn+d26aALGA@xxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
On 4/3/14, 1:21 PM, Andy Lutomirski wrote:
> On Thu, Apr 3, 2014 at 12:06 PM, Eric Sandeen <sandeen@xxxxxxxxxx> wrote:

...

>>> The various test scripts do need to be able to find the device where
>>> the file system lives, and parsing /etc/fstab would be awkward.  So if
>>> your comment is that either the /etc/fstab entry shouldn't be
>>> required, or the xfstests runtime environment should be able to derive
>>> $SCRATCH_DEV automatically from $SCRATCH_MNT, or vice versa, instead
>>
>> I guess I don't know why you'd expect to derive one from the other...
> 
> Sigh.
> 
> If $SCRATCH_MNT is specified, then the line in /etc/fstab is
> unnecessary.  If $SCRATCH_MNT is not specified, then /etc/fstab will
> do the trick.
> 
> What does not work is specifying $SCRATCH_DIR [sic] but not adding an
> fstab entry.  Oops.

Oh, I see.

I'd never really thought about xfstests devices as "part of the system" -
since they're constantly scribbled on, re-made, etc, and managed wholly
by xfstests (at least the scratch device) - so the notion of using fstab
was just outside my realm of expected behaviors.  :)

-Eric

<Prev in Thread] Current Thread [Next in Thread>