[Top] [All Lists]

[XFS updates] XFS development tree branch, xfs-bug-fixes-for-3.15-3, cre

To: xfs@xxxxxxxxxxx
Subject: [XFS updates] XFS development tree branch, xfs-bug-fixes-for-3.15-3, created. xfs-for-linus-v3.14-rc1-2-12927-gc88547a
From: xfs@xxxxxxxxxxx
Date: Thu, 3 Apr 2014 16:16:17 -0500 (CDT)
Delivered-to: xfs@xxxxxxxxxxx
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "XFS development tree".

The branch, xfs-bug-fixes-for-3.15-3 has been created
        at  c88547a8119e3b581318ab65e9b72f27f23e641d (commit)

- Log -----------------------------------------------------------------
commit c88547a8119e3b581318ab65e9b72f27f23e641d
Author: Mark Tinguely <tinguely@xxxxxxx>
Date:   Fri Apr 4 07:10:49 2014 +1100

    xfs: fix directory hash ordering bug
    Commit f5ea1100 ("xfs: add CRCs to dir2/da node blocks") introduced
    in 3.10 incorrectly converted the btree hash index array pointer in
    xfs_da3_fixhashpath(). It resulted in the the current hash always
    being compared against the first entry in the btree rather than the
    current block index into the btree block's hash entry array. As a
    result, it was comparing the wrong hashes, and so could misorder the
    entries in the btree.
    For most cases, this doesn't cause any problems as it requires hash
    collisions to expose the ordering problem. However, when there are
    hash collisions within a directory there is a very good probability
    that the entries will be ordered incorrectly and that actually
    matters when duplicate hashes are placed into or removed from the
    btree block hash entry array.
    This bug results in an on-disk directory corruption and that results
    in directory verifier functions throwing corruption warnings into
    the logs. While no data or directory entries are lost, access to
    them may be compromised, and attempts to remove entries from a
    directory that has suffered from this corruption may result in a
    filesystem shutdown.  xfs_repair will fix the directory hash
    ordering without data loss occuring.
    [dchinner: wrote useful a commit message]
    cc: <stable@xxxxxxxxxxxxxxx>
    Reported-by: Hannes Frederic Sowa <hannes@xxxxxxxxxxxxxxxxxxx>
    Signed-off-by: Mark Tinguely <tinguely@xxxxxxx>
    Reviewed-by: Ben Myers <bpm@xxxxxxx>
    Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>

commit 805eeb8e04706a16cb0b23fd4c4abbb0bc7df82d
Author: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date:   Fri Apr 4 06:56:30 2014 +1100

    xfs: extra semi-colon breaks a condition
    There were some extra semi-colons here which mean that we return true
    Fixes: a49935f200e2 ('xfs: xfs_check_page_type buffer checks need help')
    Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
    Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>
    Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
    Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>


XFS development tree

<Prev in Thread] Current Thread [Next in Thread>
  • [XFS updates] XFS development tree branch, xfs-bug-fixes-for-3.15-3, created. xfs-for-linus-v3.14-rc1-2-12927-gc88547a, xfs <=