xfs
[Top] [All Lists]

Re: [patch] xfs: extra semi-colon breaks a condition

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Subject: Re: [patch] xfs: extra semi-colon breaks a condition
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 4 Apr 2014 06:36:38 +1100
Cc: xfs@xxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140328080313.GA25192@mwanda>
References: <20140328080313.GA25192@mwanda>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Mar 28, 2014 at 11:03:13AM +0300, Dan Carpenter wrote:
> There were some extra semi-colons here which mean that we return true
> unintentionally.
> 
> Fixes: a49935f200e2 ('xfs: xfs_check_page_type buffer checks need help')
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Dan, $BEVVIE_OF_CHOICE is on me next time we are in the same place.
And bring a handful brown paper bags as well because there's a few
people here that need to wear them for a while. :/

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [patch] xfs: extra semi-colon breaks a condition, Dave Chinner <=