[Top] [All Lists]

Re: [PATCH] xfs: fix bad hash ordering

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH] xfs: fix bad hash ordering
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 1 Apr 2014 08:40:16 +1100
Cc: XFS Mailing List <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <53399B06.5010400@xxxxxxx>
References: <20140328173430.622616177@xxxxxxx> <20140331001055.GD16336@dastard> <53399B06.5010400@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Mar 31, 2014 at 11:42:46AM -0500, Mark Tinguely wrote:
> On 03/30/14 19:10, Dave Chinner wrote:
> >On Fri, Mar 28, 2014 at 12:33:34PM -0500, Mark Tinguely wrote:
> >>Fix the fix directory "bad hash ordering" bug introduced in
> >>commit f5ea1100.
> >
> ...
> >
> >>---
> >>A C program that generates this problem can be found at:
> >>  http://oss.sgi.com/archives/xfs/2014-03/msg00373.html
> >>
> >>A xfstest for this bug is coming from Hannes Frederic Sowa.
> >
> >Can you convert this program to an xfstest yourself so that I can
> >commit the regression test at the same time I commit an updated
> >fix?
> We narrowed the iterations down to make it a quick test.
> I have every confidence that Hannes can generate the test in a timely
> manner and I will help in any way possible.

Well, it's been over a week now and you're asking me to trust that
someone I don't know and who has never submitted an xfstests before
to do something in a timely manner so we can test a critical bug fix
during a merge window. I'm willing to be pleasently surprised, but
history tells me that people that report bugs rarely follow up with
xfstest cases and it's usually the developer that fixes the bug that
generates the xfstests patch.

So if the xfstests patch doesn't arrive in the next few hours, can
you please do that for us so I can get this sorted out for the merge


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>