xfs
[Top] [All Lists]

Re: [PATCH] xfs: fix bad hash ordering

To: Dave Chinner <david@xxxxxxxxxxxxx>, Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH] xfs: fix bad hash ordering
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sun, 30 Mar 2014 18:35:47 -0600
Cc: Linux Stable <stable@xxxxxxxxxxxxxxx>, XFS Mailing List <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140331001055.GD16336@dastard>
References: <20140328173430.622616177@xxxxxxx> <20140331001055.GD16336@dastard>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
On 3/30/14, 6:10 PM, Dave Chinner wrote:
> On Fri, Mar 28, 2014 at 12:33:34PM -0500, Mark Tinguely wrote:
>> Fix the fix directory "bad hash ordering" bug introduced in
>> commit f5ea1100.
> 
> The patch looks like it fixes a hashing issue, but I really can't
> tell what hashing issue it fixes from the commit message.
> 
> I don't know if you've identified the right commit just by looking
> at it - to confirm you've quoted the correct hash I have to find it,
> parse it, read the diff and try and work out whether it could have
> introduced some bug that you haven't described....
> 
> .... introduced in commit f5ea110 ("xfs: add CRCs to dir2/da node
> blocks") ....
> 
> is far more informative, even for the causal reader....
> 
> Secondly, reading that commit subject and message in isolation,
> it didn't even occur to me that this is a fix for a filesystem
> corruption bug. Any distro maintainer reading the commit logs won't
> have any idea that they need to pick this up, either.
> 
> IOWs, it is extremely important that the commit message for a
> filesystem corruption bug fix to be clearly marked as fixing a
> corruption bug, explain what the bug is, what they user visible
> symptoms are, what the impact of the corruption is, how likely users
> are going to be impacted by it, whether is causes permanent loss
> of data or not, etc. This doesn't belong in a throw-away comment to
> your fix...

But thanks a lot for jumping on the bug report & getting the fix out
on the list in short order.  ;)

-Eric

<Prev in Thread] Current Thread [Next in Thread>