xfs
[Top] [All Lists]

Re: [patch] xfs: extra semi-colon breaks a condition

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [patch] xfs: extra semi-colon breaks a condition
From: Raphael S Carvalho <raphael.scarv@xxxxxxxxx>
Date: Fri, 28 Mar 2014 23:08:58 -0300
Cc: Dan Carpenter <dan.carpenter@xxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, kernel-janitors@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=RLjEaa+yuzco6U9Zl1t76tGURlhsjheT61qvgppTIOw=; b=b72xh7VnmY3z3det2QZJsWSbftuENsfVLjrZXsxcD/qbQ4zyfAVJ5hKMfoI4LZW4G5 1SQknevUTZEhXiCg0pCqqCYthQjeJIFgzP8/ij/M3zobLXmyPBHwPoXmA2FK7YeYvsE6 sPaGsYuDaUUclFfEgvuUCw0PFSaJLGlu+7En8x4dUMbijMrYI5O2GgQDwlW71gtFO44Z T141S/LsHaMXoo7Ln1VH3OYfAw5v017WUsgBUuCPxLT8g786b16STHxjOFngFDAYxXAB ch7NkhYvLn19fZ3XD6uLXWnyxDV0YXRbIC+i47JXSlycIJVb8Rwqg2XUcwXe1g2bgE6D 0XsQ==
In-reply-to: <53362834.7090900@xxxxxxxxxxx>
References: <20140328080313.GA25192@mwanda> <53362834.7090900@xxxxxxxxxxx>



On Fri, Mar 28, 2014 at 10:56 PM, Eric Sandeen <sandeen@xxxxxxxxxxx> wrote:
On 3/28/14, 3:03 AM, Dan Carpenter wrote:
> There were some extra semi-colons here which mean that we return true
> unintentionally.
>
> Fixes: a49935f200e2 ('xfs: xfs_check_page_type buffer checks need help')

that's terrifying.
Wonder how errors like this one get into the kernel :-) Suppose it's not the main tree, but instead xfs private one.

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> index 98016b3..75df77d 100644
> --- a/fs/xfs/xfs_aops.c
> +++ b/fs/xfs/xfs_aops.c
> @@ -659,10 +659,10 @@ xfs_check_page_type(
>                       if (type == XFS_IO_UNWRITTEN)
>                               return true;
>               } else if (buffer_delay(bh)) {
> -                     if (type == XFS_IO_DELALLOC);
> +                     if (type == XFS_IO_DELALLOC)
>                               return true;
>               } else if (buffer_dirty(bh) && buffer_mapped(bh)) {
> -                     if (type == XFS_IO_OVERWRITE);
> +                     if (type == XFS_IO_OVERWRITE)
>                               return true;
>               }
>
>
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
>

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



--
Raphael S. Carvalho
<Prev in Thread] Current Thread [Next in Thread>