xfs
[Top] [All Lists]

Re: [patch] xfs: extra semi-colon breaks a condition

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [patch] xfs: extra semi-colon breaks a condition
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 28 Mar 2014 20:56:04 -0500
Cc: kernel-janitors@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140328080313.GA25192@mwanda>
References: <20140328080313.GA25192@mwanda>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
On 3/28/14, 3:03 AM, Dan Carpenter wrote:
> There were some extra semi-colons here which mean that we return true
> unintentionally.
> 
> Fixes: a49935f200e2 ('xfs: xfs_check_page_type buffer checks need help')

that's terrifying.

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> index 98016b3..75df77d 100644
> --- a/fs/xfs/xfs_aops.c
> +++ b/fs/xfs/xfs_aops.c
> @@ -659,10 +659,10 @@ xfs_check_page_type(
>                       if (type == XFS_IO_UNWRITTEN)
>                               return true;
>               } else if (buffer_delay(bh)) {
> -                     if (type == XFS_IO_DELALLOC);
> +                     if (type == XFS_IO_DELALLOC)
>                               return true;
>               } else if (buffer_dirty(bh) && buffer_mapped(bh)) {
> -                     if (type == XFS_IO_OVERWRITE);
> +                     if (type == XFS_IO_OVERWRITE)
>                               return true;
>               }
>  
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>