xfs
[Top] [All Lists]

[patch] xfs: extra semi-colon breaks a condition

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: [patch] xfs: extra semi-colon breaks a condition
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Fri, 28 Mar 2014 11:03:13 +0300
Cc: xfs@xxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-09-15)
There were some extra semi-colons here which mean that we return true
unintentionally.

Fixes: a49935f200e2 ('xfs: xfs_check_page_type buffer checks need help')
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
index 98016b3..75df77d 100644
--- a/fs/xfs/xfs_aops.c
+++ b/fs/xfs/xfs_aops.c
@@ -659,10 +659,10 @@ xfs_check_page_type(
                        if (type == XFS_IO_UNWRITTEN)
                                return true;
                } else if (buffer_delay(bh)) {
-                       if (type == XFS_IO_DELALLOC);
+                       if (type == XFS_IO_DELALLOC)
                                return true;
                } else if (buffer_dirty(bh) && buffer_mapped(bh)) {
-                       if (type == XFS_IO_OVERWRITE);
+                       if (type == XFS_IO_OVERWRITE)
                                return true;
                }
 

<Prev in Thread] Current Thread [Next in Thread>