xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfstests: Make some shared tests generic

To: Lukas Czerner <lczerner@xxxxxxxxxx>
Subject: Re: [PATCH 1/2] xfstests: Make some shared tests generic
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 26 Mar 2014 09:45:46 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1395781911-13084-1-git-send-email-lczerner@xxxxxxxxxx>
References: <1395781911-13084-1-git-send-email-lczerner@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Mar 25, 2014 at 10:11:50PM +0100, Lukas Czerner wrote:
> There are couple of tests in shared directory which really should be
> made generic, so move it. It is mostly collapse range tests, which
> really can be generic to make super we test every file system which adds
> collapse range support.
> 
> Here is what we're moving in this commit.
> 
> shared/001 -> generic/004
> shared/002 -> generic/009
> shared/003 -> generic/012
> shared/004 -> generic/016
> shared/005 -> generic/017
> shared/218 -> generic/018
> shared/305 -> generic/019
> 
> Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>
> ---
....
>  tests/shared/group    |   8 ---
>  30 files changed, 865 insertions(+), 866 deletions(-)
>  create mode 100755 tests/generic/004
>  create mode 100644 tests/generic/004.out
>  create mode 100644 tests/generic/009
>  create mode 100644 tests/generic/009.out
>  create mode 100644 tests/generic/012
>  create mode 100644 tests/generic/012.out
>  create mode 100644 tests/generic/016
>  create mode 100644 tests/generic/016.out
>  create mode 100644 tests/generic/017
>  create mode 100644 tests/generic/017.out

Looks fine at a quick glance, but can you fix the modes on these
test files (009,012...) while you are moving them?

Cheers,

Dave.

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>