[Top] [All Lists]

Re: [PATCH] xfsdump: don't assume getdents exists

To: Kyle McMartin <kmcmarti@xxxxxxxxxx>
Subject: Re: [PATCH] xfsdump: don't assume getdents exists
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sat, 22 Mar 2014 19:53:23 +1100
Cc: Eric Sandeen <sandeen@xxxxxxxxxxx>, sandeen@xxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140322051205.GB8095@xxxxxxxxxxxxxxxxxxxxxxx>
References: <20131106213635.GC24712@xxxxxxxxxxxxxxxxxxxxxxx> <52A72930.4020404@xxxxxxxxxxx> <20140322051205.GB8095@xxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sat, Mar 22, 2014 at 01:12:05AM -0400, Kyle McMartin wrote:
> On Tue, Dec 10, 2013 at 08:46:08AM -0600, Eric Sandeen wrote:
> > Hey Kyle - were you going to do a V2 of this one?
> > 
> > Just checking, thanks - 
> i've got a pair of somewhat more substantial patches to fix the ifdef
> hell in this file, clean things up so it works on both getdents64 only
> and not, and then rips out the pre-2.4.1 getdents code.
> https://github.com/jkkm/xfsdump/commit/e156bcf06effbf5f2e26c53efb0ce028c4281f9e
> https://github.com/jkkm/xfsdump/commit/fff56b471220a8fa305b9158c4f8f0c7344c8fe6
> the latter looks quite a bit better... care to take a quick look and if
> they're decent, i'll submit them both.

Please just post the patches. People will comment on them on them
once you post them to the list...


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>