xfs
[Top] [All Lists]

Re: [PATCH] xfsdump: don't assume getdents exists

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfsdump: don't assume getdents exists
From: Kyle McMartin <kmcmarti@xxxxxxxxxx>
Date: Sat, 22 Mar 2014 01:12:05 -0400
Cc: sandeen@xxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <52A72930.4020404@xxxxxxxxxxx>
References: <20131106213635.GC24712@xxxxxxxxxxxxxxxxxxxxxxx> <52A72930.4020404@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Dec 10, 2013 at 08:46:08AM -0600, Eric Sandeen wrote:
> Hey Kyle - were you going to do a V2 of this one?
> 
> Just checking, thanks - 

i've got a pair of somewhat more substantial patches to fix the ifdef
hell in this file, clean things up so it works on both getdents64 only
and not, and then rips out the pre-2.4.1 getdents code.

https://github.com/jkkm/xfsdump/commit/e156bcf06effbf5f2e26c53efb0ce028c4281f9e
https://github.com/jkkm/xfsdump/commit/fff56b471220a8fa305b9158c4f8f0c7344c8fe6

the latter looks quite a bit better... care to take a quick look and if
they're decent, i'll submit them both.

--kyle

<Prev in Thread] Current Thread [Next in Thread>