xfs
[Top] [All Lists]

Re: [PATCH] xfs: free the EFI entries from AIL on forced shutdown

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: free the EFI entries from AIL on forced shutdown
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Thu, 20 Mar 2014 15:30:26 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <532B45E1.3060309@xxxxxxx>
References: <20140314163723.916178776@xxxxxxx> <20140317052951.GE7072@dastard> <532B45E1.3060309@xxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 03/20/14 14:47, Mark Tinguely wrote:
On 03/17/14 00:29, Dave Chinner wrote:


The only case we
then have to handle specially is the xfs_trans_reserve failure in
xfs_bmap_finish(), where we need to release the EFI directly in the
error path.

any reason to not move the efd creation earlier to not special case it?

Umm, other than no ticket or space for the log_item. Never mind, we have to special case it.

--Mark.

<Prev in Thread] Current Thread [Next in Thread>