xfs
[Top] [All Lists]

Re: [PATCH v3] xfstests: shared/051: add filter to match the golden outp

To: Jeff Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH v3] xfstests: shared/051: add filter to match the golden output for large acls
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 13 Mar 2014 14:08:34 +1100
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <5320FE44.8050000@xxxxxxxxxx>
References: <5320FE44.8050000@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Mar 13, 2014 at 08:39:32AM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@xxxxxxxxxx>
> 
> On old kernel we return EINVAL if hit the limits of maximum number of
> ACLs but return E2BIG on new kernel, which cause the test failes on new
> kernel as the output is mismatch to the goldens. This patch fix it by
> updating the golden output with the new error message and replacing the
> old error message with it via a filter.
> 
> Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>
> ---
> 
> V3->V2: filter out the old error message to the new and update golden output 
> to match it
> V2->V1: filter out the new error message to the old

Looks good

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>