xfs
[Top] [All Lists]

Re: [PATCH] xfs_db: hide debug bbmap output

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfs_db: hide debug bbmap output
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 12 Mar 2014 09:51:43 +1100
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <531F33F4.40707@xxxxxxxxxxx>
References: <531F33F4.40707@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Mar 11, 2014 at 11:04:04AM -0500, Eric Sandeen wrote:
> Most of xfsprogs building with DEBUG enables extra
> checks, asserts, etc, but this bunch of printfs was
> extra output that's not generally helpful for most
> people's runtime experience - and it breaks xfs/290
> with all the noise.
> 
> I assume it's for actual debugging use, and not
> generally useful, so bury it a bit deeper under
> it's own #ifdef.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Just remove it, I think. It doesn't serve any real purpose anymore,
and changing it to an obscure ifdef guarantees it'll never get used
again...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>