xfs
[Top] [All Lists]

Re: [PATCH] xfstests: shared/051: update golden output to match the XFS

To: Jeff Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: shared/051: update golden output to match the XFS max acl return errno
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 11 Mar 2014 07:53:05 +1100
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <531D7897.2030800@xxxxxxxxxx>
References: <531D7897.2030800@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Mar 10, 2014 at 04:32:23PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@xxxxxxxxxx>
> 
> Update the golden output to match the recently XFS return errno
> changes if hit the limits of maximum number of ACLs.
> 
> Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>
> ---
>  tests/shared/051.out | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/shared/051.out b/tests/shared/051.out
> index a871082..354ec6a 100644
> --- a/tests/shared/051.out
> +++ b/tests/shared/051.out
> @@ -280,7 +280,7 @@ mask::rwx
>  other::rwx
>  
>  1 above xfs acl max
> -chacl: cannot set access acl on "largeaclfile": Invalid argument
> +chacl: cannot set access acl on "largeaclfile": Argument list too long

That breaks the test on older kernels. Can you add a filter that
kills the "Invalid argument"/"Argument list too long" part of the
error message so the same golden output works for old and new
kernels?

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>