xfs
[Top] [All Lists]

Re: [PATCH v2] xfstests: add test for btrfs send issuing premature rmdir

To: Filipe David Borba Manana <fdmanana@xxxxxxxxx>, <xfs@xxxxxxxxxxx>
Subject: Re: [PATCH v2] xfstests: add test for btrfs send issuing premature rmdir operations
From: Josef Bacik <jbacik@xxxxxx>
Date: Fri, 7 Mar 2014 13:22:19 -0500
Cc: <linux-btrfs@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fb.com; h=message-id : date : from : mime-version : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=facebook; bh=+1AiSF5aBgs/xxa1lhOca/J+kYUzU9M0HY9UZ647mQM=; b=E6ivuY8/i9UyqvkBM42SF+PmSBh5S5pov3F8ZUZKR2myNwH7xPDxg+3cRfeqwfajfPt5 KEyia0W0pnQ7ZGIXlTMNd92QlY8rlLtdtWwEmkIv9P5fAJnhdKmGX9Bf6xsi2LEu5yRm UXpq30bHoU8YUQdMyCb41BxB4xacCNmRcNE=
In-reply-to: <1393242878-16039-1-git-send-email-fdmanana@xxxxxxxxx>
References: <1392820352-8550-1-git-send-email-fdmanana@xxxxxxxxx> <1393242878-16039-1-git-send-email-fdmanana@xxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/24/2014 06:54 AM, Filipe David Borba Manana wrote:
> Regression test for btrfs incremental send issue where a rmdir
> instruction is sent against an orphan directory inode which is not
> empty yet, causing btrfs receive to fail when it attempts to remove
> the directory.
> 
> This issue is fixed by the following linux kernel btrfs patch:
> 
> Btrfs: fix send attempting to rmdir non-empty directories
> 
> Signed-off-by: Filipe David Borba Manana <fdmanana@xxxxxxxxx> ---

Looks good to me,

Reviewed-by: Josef Bacik <jbacik@xxxxxx>

Thanks,

Josef
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJTGg5bAAoJEANb+wAKly3BFtMQAMDITxFeFKRw5o5g88NUJT+n
/AQp584QUb+sBhJnyYVET98S47R4C9d7jAu8fUxUJd2FaZ0UPR+rl/LnpdYXy8oJ
29A2tvbSiOZGQp+kWlGpLqKmmEj/3R/0QZwTrB1jsxKwVsH+OGK1fazOwhkahloL
8R6xBtcvMzkBFEQ08T0dmodDaWKPp8dgztcScrVt+RGkePPVoKE9X4hwTwAl8muk
nPv9TvRULOs2emvxuTnEVqZfou0HcOTuKWXAOXN2peXBe324SjfQ0JmAMjtG1Ukw
nAs5wu8eII1k9/rjGLarNhpuSuMaM5tth0tIb2ebYwxwpYpY6o4eNN2RR6vWlCEz
vULou68VKdOG6/c6uO6cXuI8zOwScWuYyYFXFLTFpAhjdKwY1HaCwSanvnamdYy8
kNITDGkYSqs0Abj9wzQDcJcTrjpHDDe/3olb5LMJjrdTneMyDVXc+Ym+FbBhmQUX
d7vC+a7sRVWwN4xGoqxDgZZQLpGBEO60FhA5kIO9lgis2LdG8SXE0ch4sQuWZ8iC
S9Aw46dssmiY+d3BkugCOPW/7IlID/obLGUF+CWcWMkxSMbwaPn6RfNJmW+9k+rv
fkUVj+U75pBtnuwW3LxV7gUq8HwTz8G1fh+96o41yKXpayBQUoIA47AHCUZtP9Fi
RemqwFmZxhi7ztZYfni2
=8Kl8
-----END PGP SIGNATURE-----

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH v2] xfstests: add test for btrfs send issuing premature rmdir operations, Josef Bacik <=