xfs
[Top] [All Lists]

Re: [PATCH v2 6/8] fsstress: translate flags in fiemap_f

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH v2 6/8] fsstress: translate flags in fiemap_f
From: Lukáš Czerner <lczerner@xxxxxxxxxx>
Date: Thu, 6 Mar 2014 19:02:16 +0100 (CET)
Cc: linux-ext4@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140306174813.GE28297@xxxxxxxxxxxxx>
References: <1394034699-21187-1-git-send-email-lczerner@xxxxxxxxxx> <1394034699-21187-7-git-send-email-lczerner@xxxxxxxxxx> <20140306174813.GE28297@xxxxxxxxxxxxx>
User-agent: Alpine 2.00 (LFD 1167 2008-08-23)
On Thu, 6 Mar 2014, Christoph Hellwig wrote:

> Date: Thu, 6 Mar 2014 09:48:13 -0800
> From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
> To: Lukas Czerner <lczerner@xxxxxxxxxx>
> Cc: linux-ext4@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
> Subject: Re: [PATCH v2 6/8] fsstress: translate flags in fiemap_f
> 
> > +#ifdef HAVE_LINUX_FIEMAP_H
> > +struct print_flags fiemap_flags[] = {
> > +   { FIEMAP_FLAG_SYNC, "SYNC"},
> > +   { FIEMAP_FLAG_XATTR, "XATTR"},
> > +   { -1, NULL}
> > +};
> 
> Can be static.

Right. The same applies to falloc_flags

> 
> > +
> > +#define translate_fiemap_flags(mode)       \
> > +   ({translate_flags(mode, "|", fiemap_flags);})
> > +#endif
> 
> Any reason to not have these two inside fiemap_f?

Not really, other than I think it's ugly.

> 
> Otherwise:
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Thanks!
-Lukas

> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

<Prev in Thread] Current Thread [Next in Thread>