| To: | Lukas Czerner <lczerner@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH v2 6/8] fsstress: translate flags in fiemap_f |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Thu, 6 Mar 2014 09:48:13 -0800 |
| Cc: | linux-ext4@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1394034699-21187-7-git-send-email-lczerner@xxxxxxxxxx> |
| References: | <1394034699-21187-1-git-send-email-lczerner@xxxxxxxxxx> <1394034699-21187-7-git-send-email-lczerner@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
> +#ifdef HAVE_LINUX_FIEMAP_H
> +struct print_flags fiemap_flags[] = {
> + { FIEMAP_FLAG_SYNC, "SYNC"},
> + { FIEMAP_FLAG_XATTR, "XATTR"},
> + { -1, NULL}
> +};
Can be static.
> +
> +#define translate_fiemap_flags(mode) \
> + ({translate_flags(mode, "|", fiemap_flags);})
> +#endif
Any reason to not have these two inside fiemap_f?
Otherwise:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
|
| Previous by Date: | Re: [PATCH v2 4/8] xfstests: Move fallocate include into global.h, Christoph Hellwig |
|---|---|
| Next by Date: | Test komputera oraz internetu - online, testuj-online.pl |
| Previous by Thread: | [PATCH v2 6/8] fsstress: translate flags in fiemap_f, Lukas Czerner |
| Next by Thread: | Re: [PATCH v2 6/8] fsstress: translate flags in fiemap_f, Lukáš Czerner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |