xfs
[Top] [All Lists]

Re: [PATCH v2 2/8] xfstests: create _test_block_boundaries in common/pun

To: Lukas Czerner <lczerner@xxxxxxxxxx>
Subject: Re: [PATCH v2 2/8] xfstests: create _test_block_boundaries in common/punch
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 6 Mar 2014 09:45:41 -0800
Cc: linux-ext4@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1394034699-21187-3-git-send-email-lczerner@xxxxxxxxxx>
References: <1394034699-21187-1-git-send-email-lczerner@xxxxxxxxxx> <1394034699-21187-3-git-send-email-lczerner@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
Looks good, but having a comment explaining the function would be
helpful given that the name isn't entirely self-describing.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>