xfs
[Top] [All Lists]

Re: [PATCH v2 1/8] xfstests: Create single function for testing xfs_io c

To: Lukas Czerner <lczerner@xxxxxxxxxx>
Subject: Re: [PATCH v2 1/8] xfstests: Create single function for testing xfs_io commands
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 6 Mar 2014 09:44:20 -0800
Cc: linux-ext4@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1394034699-21187-2-git-send-email-lczerner@xxxxxxxxxx>
References: <1394034699-21187-1-git-send-email-lczerner@xxxxxxxxxx> <1394034699-21187-2-git-send-email-lczerner@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Mar 05, 2014 at 04:51:32PM +0100, Lukas Czerner wrote:
> Currently there are several function testing various xfs_io commands.
> This commit creates _require_xfs_io_command() to test any xfs_command.

Looks good.  Do you plan to keep the wrappers around
_require_xfs_io_command in the long run or just for a transitional
period?

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>