xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfs: inode log reservations are still too small

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/2] xfs: inode log reservations are still too small
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 5 Mar 2014 14:34:28 -0800
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140305214002.GI6851@dastard>
References: <1393981893-2497-1-git-send-email-david@xxxxxxxxxxxxx> <1393981893-2497-3-git-send-email-david@xxxxxxxxxxxxx> <20140305171441.GD11667@xxxxxxxxxxxxx> <20140305214002.GI6851@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
> We don't. We need to, I just haven't had the time to audit the rest
> of the reservations to fix them all up yet. AFAIA, only the quota
> off transactions don't have any slack in them for xlog_op_header
> space - all the others that are incorrect probably have enough
> overhead from the buffer overhead roundup to cover the lack ophdr
> accounting on things like dquots.

That's more or less what I expected..

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>