| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/2] xfs: inode log reservations are still too small |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Thu, 6 Mar 2014 08:40:02 +1100 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20140305171441.GD11667@xxxxxxxxxxxxx> |
| References: | <1393981893-2497-1-git-send-email-david@xxxxxxxxxxxxx> <1393981893-2497-3-git-send-email-david@xxxxxxxxxxxxx> <20140305171441.GD11667@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Wed, Mar 05, 2014 at 09:14:41AM -0800, Christoph Hellwig wrote: > The fix looks correct, but care to remind me where we account for the > xlog_op_header for all non-buf, non-inode transaction? We don't. We need to, I just haven't had the time to audit the rest of the reservations to fix them all up yet. AFAIA, only the quota off transactions don't have any slack in them for xlog_op_header space - all the others that are incorrect probably have enough overhead from the buffer overhead roundup to cover the lack ophdr accounting on things like dquots. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] xfsdump: Fix memory leak in invutil/stobj.c, Boris Ranto |
|---|---|
| Next by Date: | Re: [PATCH 1/2] xfs: xfs_check_page_type buffer checks need help, Brian Foster |
| Previous by Thread: | Re: [PATCH 2/2] xfs: inode log reservations are still too small, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 2/2] xfs: inode log reservations are still too small, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |