xfs
[Top] [All Lists]

Re: [PATCH] xfstests: memset proper length in resvtest.c

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: memset proper length in resvtest.c
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Tue, 4 Mar 2014 10:36:55 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <531563D8.2070007@xxxxxxxxxx>
References: <531563D8.2070007@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Mar 03, 2014 at 11:25:44PM -0600, Eric Sandeen wrote:
> sizeof(pointer) is not very relevant; sizeof(*pointer)
> is a bit more so.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> 
> diff --git a/src/resvtest.c b/src/resvtest.c
> index 037d9ea..a07f503 100644
> --- a/src/resvtest.c
> +++ b/src/resvtest.c
> @@ -73,7 +73,7 @@ main(int argc, char **argv)
>               perror("open");
>               exit(1);
>       }
> -     memset(writebuffer, 'A', sizeof(writebuffer));
> +     memset(writebuffer, 'A', sizeof(*writebuffer));
>

It's not clear to me how much this is intending to write/read. If the
entire buffer, we should probably use the buffer size.
sizeof(*writebuffer) is a single byte, no?

Also, there are other instances of the same thing throughout this file.
I think they need to be consistent, in any event, for the test to work.

Brian

>       unlink(filename);
>       writefd = open(filename, O_RDWR | O_CREAT | O_EXCL, S_IRUSR | S_IWUSR);
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>