xfs
[Top] [All Lists]

Re: [PATCH V2] xfstests: fix error msg in aio-dio-subblock-eof-read.c

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH V2] xfstests: fix error msg in aio-dio-subblock-eof-read.c
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Tue, 4 Mar 2014 10:05:11 -0500
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <5315681C.5070704@xxxxxxxxxxx>
References: <53156389.4060405@xxxxxxxxxx> <5315681C.5070704@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Mar 03, 2014 at 11:43:56PM -0600, Eric Sandeen wrote:
> io_getevents returns the number of events; printing its
> return as "bytes read" is ... wrong.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> 
> V2: print as signed so we can easily see errors returned
> 

Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>

> diff --git a/src/aio-dio-regress/aio-dio-subblock-eof-read.c 
> b/src/aio-dio-regress/aio-dio-subblock-eof-read.c
> index a48841d..8f74cec 100644
> --- a/src/aio-dio-regress/aio-dio-subblock-eof-read.c
> +++ b/src/aio-dio-regress/aio-dio-subblock-eof-read.c
> @@ -105,8 +107,8 @@ main(int argc, char **argv)
>        *  are broken, we may very well see a result of 4k.
>        */
>       if (ie.res != FILE_SIZE)
> -             fail("AIO read of last block in file returned %d bytes, "
> -                  "expected %d\n", ret, FILE_SIZE);
> +             fail("AIO read of last block in file returned %ld bytes, "
> +                  "expected %d\n", ie.res, FILE_SIZE);
>  
>       printf("AIO read of last block in file succeeded.\n");
>       return 0;
> 
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>