xfs
[Top] [All Lists]

Re: [PATCH 5/8] xfstests: Add fallocate zero range operation to fsstress

To: Lukas Czerner <lczerner@xxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx
Subject: Re: [PATCH 5/8] xfstests: Add fallocate zero range operation to fsstress
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 28 Feb 2014 11:40:08 -0600
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1393603865-26198-5-git-send-email-lczerner@xxxxxxxxxx>
References: <1393603865-26198-1-git-send-email-lczerner@xxxxxxxxxx> <1393603865-26198-5-git-send-email-lczerner@xxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.3.0
On 2/28/14, 10:11 AM, Lukas Czerner wrote:
> This commit adds fzero operation support for fsstress, which is meant to
> exercise fallocate FALLOC_FL_ZERO_RANGE support.
> 
> Also reorganise the common fallocate code into a single do_fallocate()
> function and use flags use the right mode.
> 
> Also in order to make more obvious which fallocate mode fsstress is
> testing translate fallocate flags into human readable strings.

Can you enhance that so that if it's passed a flag which isn't
in the known array, it prints the leftover values?  Otherwise
they are silently dropped, which might be confusing.

Handling the case where a flag is not in the array would future-proof
it, I think.

-Eric

<Prev in Thread] Current Thread [Next in Thread>