| To: | Eric Sandeen <sandeen@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs_io: add missing break in O_TMPFILE case |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Fri, 28 Feb 2014 07:25:44 +1100 |
| Cc: | xfs-oss <xfs@xxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <530F9D31.5070103@xxxxxxxxxx> |
| References: | <530F9D31.5070103@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Thu, Feb 27, 2014 at 02:16:49PM -0600, Eric Sandeen wrote: > Coverity spotted this. > > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> > --- > > (I assume that -T isn't supposed to imply -x?) > > diff --git a/io/init.c b/io/init.c > index fd1a52f..1e2690e 100644 > --- a/io/init.c > +++ b/io/init.c > @@ -181,6 +181,7 @@ init( > break; > case 'T': > flags |= IO_TMPFILE; > + break; > case 'x': > expert = 1; > break; Looks good. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] xfs_io: don't leak fd in open -Tr failure case, Eric Sandeen |
|---|---|
| Next by Date: | Re: [PATCH] xfs_io: don't leak fd in open -Tr failure case, Eric Sandeen |
| Previous by Thread: | Re: [PATCH] xfs_io: add missing break in O_TMPFILE case, Christoph Hellwig |
| Next by Thread: | [PATCH] xfs_io: don't leak fd in open -Tr failure case, Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |