xfs
[Top] [All Lists]

Re: [PATCH] XFS: fix the description of 'allocsize=' mount option

To: sat <takeuchi_satoru@xxxxxxxxxxxxxx>
Subject: Re: [PATCH] XFS: fix the description of 'allocsize=' mount option
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 27 Feb 2014 17:42:21 +1100
Cc: xfs@xxxxxxxxxxx, Rob Landley <rob@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <530D6FE3.2040406@xxxxxxxxxxxxxx>
References: <530AE0E5.1090707@xxxxxxxxxxxxxx> <20140224120629.GN4317@dastard> <530D6FE3.2040406@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Feb 26, 2014 at 01:38:59PM +0900, sat wrote:
> Hi Dave,
> 
> >Actually, it isn't. The initial size of dynamic prealloc is
> >determined by a set of heuristics based on file size, filesystem
> >geometry and the existing extents on the file. It uses a default
> >of 64k if no optimisation heuristics trigger.
> 
> I see. I should have read the code more carefully.
> 
> ---
> From: Satoru Takeuchi <takeuchi_satoru@xxxxxxxxxxxxxx>
> Subject: [PATCH] XFS: remove the description about the default value of 
> "allocsize=" mount option
> 
> The end-of-file preallocation size is dynamic by default.
> So there is no static default size specified by "allocsize="
> mount option and the description about the default size
> should be removed.
> 
> Signed-off-by: Satoru Takeuchi <takeuchi_satoru@xxxxxxxxxxxxxx>
> Cc: Dave Chinner <david@xxxxxxxxxxxxx>
> Cc: Rob Landley <rob@xxxxxxxxxxx>

Looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>