xfs
[Top] [All Lists]

Re: [PATCH] xfs_io: add fzero command for zeroing range via fallocate

To: Lukas Czerner <lczerner@xxxxxxxxxx>
Subject: Re: [PATCH] xfs_io: add fzero command for zeroing range via fallocate
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 27 Feb 2014 16:01:50 +1100
Cc: linux-ext4@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1393355733-12099-1-git-send-email-lczerner@xxxxxxxxxx>
References: <1393355733-12099-1-git-send-email-lczerner@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Feb 25, 2014 at 08:15:33PM +0100, Lukas Czerner wrote:
> Add fzero command which zeroes a range of the file using
> fallocate FALLOC_FL_ZERO_RANGE flag.
> 
> Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>

Looks ok, but...

> @@ -312,7 +342,17 @@ prealloc_init(void)
>       fcollapse_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK;
>       fcollapse_cmd.args = _("off len");
>       fcollapse_cmd.oneline =
> -     _("de-allocates space and eliminates the hole by shifting extents");
> +             _("de-allocates space and eliminates the hole by shifting 
> extents");
>       add_command(&fcollapse_cmd);

I'll drop this change because it pushes the line beyond 80
characters....

Otherwise,

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>