| To: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 7/9 V2] xfs: add xfs_verifier_error() |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Thu, 27 Feb 2014 15:20:53 +1100 |
| Cc: | Eric Sandeen <sandeen@xxxxxxxxxx>, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <53056F43.7070005@xxxxxxxxxxx> |
| References: | <1392767549-25574-1-git-send-email-sandeen@xxxxxxxxxx> <1392767549-25574-8-git-send-email-sandeen@xxxxxxxxxx> <53056F43.7070005@xxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Wed, Feb 19, 2014 at 08:58:11PM -0600, Eric Sandeen wrote: > We want to distinguish between corruption, CRC errors, > etc. In addition, the full stack trace on verifier errors > seems less than helpful; it looks more like an oops than > corruption. > > Create a new function to specifically alert the user to > verifier errors, which can differentiate between > EFSCORRUPTED and CRC mismatches. It doesn't dump stack > unless the xfs error level is turned up high. > > Define a new error message (EFSBADCRC) to clearly identify > CRC errors. (Defined to EILSEQ, bad byte sequence) I've updated this to be EBADMSG, to match the code. Otherwise, looks good. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 5/9] xfs: add helper for verifying checksums on xfs_bufs, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 5/6 v2] ext4: Introduce FALLOC_FL_ZERO_RANGE flag for fallocate, jon ernst |
| Previous by Thread: | [PATCH 7/9 V2] xfs: add xfs_verifier_error(), Eric Sandeen |
| Next by Thread: | [PATCH 4/9] xfs: Use defines for CRC offsets in all cases, Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |