xfs
[Top] [All Lists]

Re: [PATCH] util-linux/fallocate: introduce an option -c to support FALL

To: Dongsu Park <dongsu.park@xxxxxxxxxxxxxxxx>, Karel Zak <kzak@xxxxxxxxxx>
Subject: Re: [PATCH] util-linux/fallocate: introduce an option -c to support FALLOC_FL_COLLAPSE_RANGE
From: Namjae Jeon <linkinjeon@xxxxxxxxx>
Date: Thu, 27 Feb 2014 12:59:51 +0900
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, tytso@xxxxxxx, Lukas Czerner <lczerner@xxxxxxxxxx>, Namjae Jeon <namjae.jeon@xxxxxxxxxxx>, Ashish Sangwan <a.sangwan@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=qR6LPLku/DJ2tsBBdCHmZP4t1sq5fYxtkzioW60nBho=; b=MYK9sadyJpDBTDWl1tU02h1gBez2wCTlfxkh/+PdwU4XmxnCtS894xtBLITvnmAxdh rJJSkAExf5LARLc6P/fQbsWH9Jg1XvmmN4BG4O4Qeqb6f2uMV9f7uyYhpjNpOrwtf/HQ VOya5RZBe4EYJTg5vKw1z3N5WCVhcw16kwH3YWzWakr/9dcNXlohWBvaydfP/s73dqmo 22nFTzZVD0EkLvTYERCm8am/s6h7rX8pcJNzVu4mQrQBWrta0LhinoI1R4UAxl+nSgFG I7tETRi7iNQ81OVHABW4GfhByZe6yRmbHG6C1MGpKPO3elgnO3ArIeeQhX23XvdfQ+y9 WqEg==
In-reply-to: <1393355305-12009-1-git-send-email-dongsu.park@xxxxxxxxxxxxxxxx>
References: <alpine.LFD.2.00.1402181001530.2216@xxxxxxxxxxxxxxxxxxxxx> <1393355305-12009-1-git-send-email-dongsu.park@xxxxxxxxxxxxxxxx>
Hi Dongsu.
> As discussed in the thread "[PATCH RESEND 3/10] ext4: Add support
> FALLOC_FL_COLLAPSE_RANGE for fallocate", [3] this patch to util-linux
> will be useful for testing collapse-range inside xfstests.
As Dave pointed, this patch is needed for fsstress not xfstests.
>
> [1] https://lkml.org/lkml/2014/2/18/374
> [2] https://lkml.org/lkml/2014/2/20/318
> [3] https://lkml.org/lkml/2014/2/18/83
>
> @@ -51,6 +52,10 @@
>  # define FALLOC_FL_PUNCH_HOLE 2
>  #endif
>
> +#ifndef FALLOC_FL_COLLAPSE_RANGE
> +# define FALLOC_FL_COLLAPSE_RANGE 8
> +#endif
> +
>  #include "nls.h"
>  #include "strutils.h"
>  #include "c.h"
> @@ -66,12 +71,13 @@ static void __attribute__((__noreturn__)) usage(FILE
> *out)
>       fprintf(out,
>             _(" %s [options] <filename>\n"), program_invocation_short_name);
>       fputs(USAGE_OPTIONS, out);
> -     fputs(_(" -d, --dig-holes     detect and dig holes\n"), out);
> -     fputs(_(" -l, --length <num>  length of the (de)allocation, in 
> bytes\n"),
> out);
> -     fputs(_(" -n, --keep-size     don't modify the length of the file\n"),
> out);
> -     fputs(_(" -o, --offset <num>  offset of the (de)allocation, in 
> bytes\n"),
> out);
> -     fputs(_(" -p, --punch-hole    punch holes in the file\n"), out);
> -     fputs(_(" -v, --verbose       verbose mode\n"), out);
> +     fputs(_(" -c, --collapse-range collapse a hole in the file\n"), out);
I think that it is better to change like this => "collapse space in the file"
And I add util-liunx's maintainer in this mail loop.

Thanks.

<Prev in Thread] Current Thread [Next in Thread>