Re: [PATCH 06/10] repair: use a listhead for the dotdot list

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 06/10] repair: use a listhead for the dotdot list
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Thu, 27 Feb 2014 13:06:24 +1100
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20140225200332.GB22351@xxxxxxxxxxxxx>
References:	<1393223369-4696-1-git-send-email-david@xxxxxxxxxxxxx> <1393223369-4696-7-git-send-email-david@xxxxxxxxxxxxx> <20140225200332.GB22351@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Tue, Feb 25, 2014 at 12:03:32PM -0800, Christoph Hellwig wrote:
> On Mon, Feb 24, 2014 at 05:29:25PM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > Cleanup suggested by Christoph Hellwig - removes another open coded
> > list implementation.
> 
> Looks good.  Question for both the old and new code:  any good reason to
> do the dotdot updates LIFO?  If yes it might be worth adding a comment
> about that fact.

No, it didn't even occur to me that it might matter. I'll change it
back to FIFO.

> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Thanks,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 10/10] repair: BMBT prefetch needs to be CRC aware, (continued) [PATCH 10/10] repair: BMBT prefetch needs to be CRC aware, Dave Chinner Re: [PATCH 10/10] repair: BMBT prefetch needs to be CRC aware, Christoph Hellwig Re: [PATCH 10/10] repair: BMBT prefetch needs to be CRC aware, Dave Chinner Re: [PATCH 10/10] repair: BMBT prefetch needs to be CRC aware, Christoph Hellwig Re: [PATCH 10/10] repair: BMBT prefetch needs to be CRC aware, Christoph Hellwig [PATCH 07/10] repair: prefetch runs too far ahead, Dave Chinner Re: [PATCH 07/10] repair: prefetch runs too far ahead, Christoph Hellwig Re: [PATCH 07/10] repair: prefetch runs too far ahead, Dave Chinner [PATCH 06/10] repair: use a listhead for the dotdot list, Dave Chinner Re: [PATCH 06/10] repair: use a listhead for the dotdot list, Christoph Hellwig Re: [PATCH 06/10] repair: use a listhead for the dotdot list, Dave Chinner <= [PATCH 03/10] libxfs: buffer cache hashing is suboptimal, Dave Chinner [PATCH 05/10] repair: factor out threading setup code, Dave Chinner Re: [PATCH 05/10] repair: factor out threading setup code, Brian Foster Re: [PATCH 05/10] repair: factor out threading setup code, Dave Chinner Re: [PATCH 05/10] repair: factor out threading setup code, Brian Foster [PATCH 09/10] repair: fix prefetch queue limiting, Dave Chinner Re: [PATCH 09/10] repair: fix prefetch queue limiting, Christoph Hellwig [PATCH 01/10] repair: translation lookups limit scalability, Dave Chinner Re: [PATCH 01/10] repair: translation lookups limit scalability, Brian Foster Re: [PATCH 01/10] repair: translation lookups limit scalability, Christoph Hellwig

Previous by Date:	Re: [PATCH v5 0/10] fs: Introduce new flag(FALLOC_FL_COLLAPSE_RANGE) for fallocate, Hugh Dickins
Next by Date:	Re: [PATCH 4/9] xfs: Use defines for CRC offsets in all cases, Dave Chinner
Previous by Thread:	Re: [PATCH 06/10] repair: use a listhead for the dotdot list, Christoph Hellwig
Next by Thread:	[PATCH 03/10] libxfs: buffer cache hashing is suboptimal, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]