xfs
[Top] [All Lists]

Re: [PATCH 06/10] repair: use a listhead for the dotdot list

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 06/10] repair: use a listhead for the dotdot list
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 27 Feb 2014 13:06:24 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140225200332.GB22351@xxxxxxxxxxxxx>
References: <1393223369-4696-1-git-send-email-david@xxxxxxxxxxxxx> <1393223369-4696-7-git-send-email-david@xxxxxxxxxxxxx> <20140225200332.GB22351@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Feb 25, 2014 at 12:03:32PM -0800, Christoph Hellwig wrote:
> On Mon, Feb 24, 2014 at 05:29:25PM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > Cleanup suggested by Christoph Hellwig - removes another open coded
> > list implementation.
> 
> Looks good.  Question for both the old and new code:  any good reason to
> do the dotdot updates LIFO?  If yes it might be worth adding a comment
> about that fact.

No, it didn't even occur to me that it might matter. I'll change it
back to FIFO.

> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Thanks,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>