| To: | Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx> |
|---|---|
| Subject: | [PATCH 2/2] xfs_logprint: don't advance op counter in xlog_print_trans_icreate |
| From: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
| Date: | Wed, 26 Feb 2014 19:15:52 -0600 |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <530E8E17.1090901@xxxxxxxxxx> |
| References: | <530E8E17.1090901@xxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
xlog_print_trans_icreate is advancing the op counter
"(*i)++" incorrectly; it only contains one region, and
the loop which called it will properly advance the op
once we're done.
Found-by: Dave Chinner <dchinner@xxxxxxxxxx>
Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
---
diff --git a/logprint/log_misc.c b/logprint/log_misc.c
index 7070fa3..52f1e85 100644
--- a/logprint/log_misc.c
+++ b/logprint/log_misc.c
@@ -810,7 +810,6 @@ xlog_print_trans_icreate(
memmove(&icl_buf, *ptr, MIN(sizeof(struct xfs_icreate_log), len));
icl = &icl_buf;
- (*i)++;
*ptr += len;
/* handle complete header only */
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 1/2] xfs_logprint: Don't error out after split items lose context, Eric Sandeen |
|---|---|
| Next by Date: | Re: [PATCH v5 0/10] fs: Introduce new flag(FALLOC_FL_COLLAPSE_RANGE) for fallocate, Dave Chinner |
| Previous by Thread: | Re: [PATCH 1/2] xfs_logprint: Don't error out after split items lose context, Dave Chinner |
| Next by Thread: | Re: [PATCH 2/2] xfs_logprint: don't advance op counter in xlog_print_trans_icreate, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |