xfs
[Top] [All Lists]

Re: [PATCH 08/10] libxfs: remove a couple of locks

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 08/10] libxfs: remove a couple of locks
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 26 Feb 2014 16:53:33 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140226015432.GC3616@xxxxxxxxxxxxx>
References: <1393223369-4696-1-git-send-email-david@xxxxxxxxxxxxx> <1393223369-4696-9-git-send-email-david@xxxxxxxxxxxxx> <20140225200558.GC22351@xxxxxxxxxxxxx> <20140225234357.GJ13647@dastard> <20140226015432.GC3616@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Feb 25, 2014 at 05:54:32PM -0800, Christoph Hellwig wrote:
> On Wed, Feb 26, 2014 at 10:43:57AM +1100, Dave Chinner wrote:
> > On Tue, Feb 25, 2014 at 12:05:58PM -0800, Christoph Hellwig wrote:
> > > So what's protecting the cache hits statistics now?
> > 
> > Nothing. And I don't care because the statistic is meaningless from
> > the point of view of tuning xfs_repair performance.
> 
> In that case I think it's better to just remove c_hits instead of
> updating it in a racy way.

I didn't say it's completely meaningless - it's handy for debugging,
just not useful to end users and so accuracy isn't important enough
to use a global lock on.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>