xfs
[Top] [All Lists]

Re: [PATCH] XFS: fix the description of 'allocsize=' mount option

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] XFS: fix the description of 'allocsize=' mount option
From: sat <takeuchi_satoru@xxxxxxxxxxxxxx>
Date: Wed, 26 Feb 2014 13:38:59 +0900
Cc: <xfs@xxxxxxxxxxx>, Rob Landley <rob@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140224120629.GN4317@dastard>
References: <530AE0E5.1090707@xxxxxxxxxxxxxx> <20140224120629.GN4317@dastard>
User-agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.3.0
Hi Dave,

Actually, it isn't. The initial size of dynamic prealloc is
determined by a set of heuristics based on file size, filesystem
geometry and the existing extents on the file. It uses a default
of 64k if no optimisation heuristics trigger.

I see. I should have read the code more carefully.

---
From: Satoru Takeuchi <takeuchi_satoru@xxxxxxxxxxxxxx>
Subject: [PATCH] XFS: remove the description about the default value of 
"allocsize=" mount option

The end-of-file preallocation size is dynamic by default.
So there is no static default size specified by "allocsize="
mount option and the description about the default size
should be removed.

Signed-off-by: Satoru Takeuchi <takeuchi_satoru@xxxxxxxxxxxxxx>
Cc: Dave Chinner <david@xxxxxxxxxxxxx>
Cc: Rob Landley <rob@xxxxxxxxxxx>
---
 Documentation/filesystems/xfs.txt |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/filesystems/xfs.txt 
b/Documentation/filesystems/xfs.txt
index 5be51fd..5837f0a 100644
--- a/Documentation/filesystems/xfs.txt
+++ b/Documentation/filesystems/xfs.txt
@@ -23,9 +23,9 @@ default behaviour.
allocsize=size
     Sets the buffered I/O end-of-file preallocation size when
-    doing delayed allocation writeout (default size is 64KiB).
-    Valid values for this option are page size (typically 4KiB)
-    through to 1GiB, inclusive, in power-of-2 increments.
+    doing delayed allocation writeout. Valid values for this
+    option are page size (typically 4KiB) through to 1GiB,
+    inclusive, in power-of-2 increments.
The default behaviour is for dynamic end-of-file
     preallocation size, which uses a set of heuristics to
--
1.7.1



<Prev in Thread] Current Thread [Next in Thread>