[Top] [All Lists]

Re: [PATCH] xfs_copy: accept XFS_ABTB_CRC_MAGIC

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfs_copy: accept XFS_ABTB_CRC_MAGIC
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 25 Feb 2014 18:07:37 -0800
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <530D4B68.9090905@xxxxxxxxxx>
References: <530D4B68.9090905@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Feb 25, 2014 at 08:03:20PM -0600, Eric Sandeen wrote:
> xfs_copy needs a fair bit of work for CRCs because it rewrites
> UUIDs by default, but this change will get it working properly
> with the "-d" (duplicate) option which keeps the same UUID.

I don't think ASSERTs for user supplied data are a good idea, this
should be some real error handling.

> However, I wonder if we should fail CRC filesystems outright
> for now if -d isn't specified, because it will invalidate every
> CRC and generally make a mess of things...

Yeah, for now it probably should be rejected.

It would also be useful to have a list of such issues in an README.v5
or TODO.v5 file in the xfsprogs tree.

<Prev in Thread] Current Thread [Next in Thread>