| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 08/10] libxfs: remove a couple of locks |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Wed, 26 Feb 2014 10:43:57 +1100 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20140225200558.GC22351@xxxxxxxxxxxxx> |
| References: | <1393223369-4696-1-git-send-email-david@xxxxxxxxxxxxx> <1393223369-4696-9-git-send-email-david@xxxxxxxxxxxxx> <20140225200558.GC22351@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Feb 25, 2014 at 12:05:58PM -0800, Christoph Hellwig wrote: > So what's protecting the cache hits statistics now? Nothing. And I don't care because the statistic is meaningless from the point of view of tuning xfs_repair performance. > Longer term it might make sense to just port the XFS buffercache from > the kernel to libxfs.. *nod* We badly need to separate the buffer cache into per-AG caches because most of the per-thread operations are isolated to a single AG and so a global hash simply doesn't scale from a lock contention or a table sizing point of view.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| Previous by Date: | Re: [PATCH v5 1/10] fs: Add new flag(FALLOC_FL_COLLAPSE_RANGE) for fallocate, Hugh Dickins |
|---|---|
| Next by Date: | Re: [PATCH 10/10] repair: BMBT prefetch needs to be CRC aware, Dave Chinner |
| Previous by Thread: | Re: [PATCH 08/10] libxfs: remove a couple of locks, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 08/10] libxfs: remove a couple of locks, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |