[Top] [All Lists]

Re: [PATCH 08/10] libxfs: remove a couple of locks

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 08/10] libxfs: remove a couple of locks
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 26 Feb 2014 10:43:57 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140225200558.GC22351@xxxxxxxxxxxxx>
References: <1393223369-4696-1-git-send-email-david@xxxxxxxxxxxxx> <1393223369-4696-9-git-send-email-david@xxxxxxxxxxxxx> <20140225200558.GC22351@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Feb 25, 2014 at 12:05:58PM -0800, Christoph Hellwig wrote:
> So what's protecting the cache hits statistics now?

Nothing. And I don't care because the statistic is meaningless from
the point of view of tuning xfs_repair performance.

> Longer term it might make sense to just port the XFS buffercache from
> the kernel to libxfs..


We badly need to separate the buffer cache into per-AG caches
because most of the per-thread operations are isolated to a single
AG and so a global hash simply doesn't scale from a lock contention
or a table sizing point of view....


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>