xfs
[Top] [All Lists]

Re: [PATCH 4/6] shared/051: CRC enabled filesystems handle more than 25

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/6] shared/051: CRC enabled filesystems handle more than 25 ACLs
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 25 Feb 2014 14:09:11 -0800
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1393211175-30016-5-git-send-email-david@xxxxxxxxxxxxx>
References: <1393211175-30016-1-git-send-email-david@xxxxxxxxxxxxx> <1393211175-30016-5-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Feb 24, 2014 at 02:06:13PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> shared/051 fails on CRC enabled filesystems because it doesn't get
> an erro on setting the 26th ACL on a file. CRC enabled filesystems
> support more than 25, so there shoul dbe no error.
> 
> Allow the test to pass on both non-CRC and CRC enabled filesystems
> by detecting the type of filesystem configuration and using that
> information to fake the error message so that the golden output
> match does not fail. We also need to filter the 26th ACL from the
> output otherwise that will cause failures, too.

I don't really like this - we'd better of defining a function saying how
many ACEs a filesystem supports and use that.  Also I think the test for
these large ACLs should be a separate test from the other tests
currently in 051 as it's been causing a fair amount of issues in the
past with various filesystems.

<Prev in Thread] Current Thread [Next in Thread>