Re: [PATCH] xfs_metadump: include F in getopts string

xfs

Re: [PATCH] xfs_metadump: include F in getopts string

To:	Eric Sandeen <sandeen@xxxxxxxxxx>
Subject:	Re: [PATCH] xfs_metadump: include F in getopts string
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Tue, 25 Feb 2014 14:03:28 -0800
Cc:	xfs-oss <xfs@xxxxxxxxxxx>, Boris Ranto <branto@xxxxxxxxxx>
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<530CC371.8030005@xxxxxxxxxx>
References:	<530CC371.8030005@xxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Tue, Feb 25, 2014 at 10:23:13AM -0600, Eric Sandeen wrote:
> I added an F case, but didn't add it to the bash
> getopts string last go-round.
> 
> /usr/sbin/xfs_metadump: illegal option -- F
> 
> I sure thought I tested this, I'm not sure how it got lost.

Well, better write a test for xfstests so that we can test it as part of
the regression test run.

Otherwise:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] xfs_metadump: include F in getopts string, Eric Sandeen Re: [PATCH] xfs_metadump: include F in getopts string, Mark Tinguely Re: [PATCH] xfs_metadump: include F in getopts string, Christoph Hellwig <=

Previous by Date:	Re: [PATCH 5/6] xfstests: Define fallocate flags locally in fsx, Christoph Hellwig
Next by Date:	Re: [PATCH 6/6] ext4/242: Add ext4 specific test for fallocate zero range, Lukáš Czerner
Previous by Thread:	Re: [PATCH] xfs_metadump: include F in getopts string, Mark Tinguely
Next by Thread:	[PATCH] xfstests: add test for btrfs-progs restore feature, Filipe David Borba Manana
Indexes:	[Date] [Thread] [Top] [All Lists]