xfs
[Top] [All Lists]

Re: [PATCH 06/10] repair: use a listhead for the dotdot list

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 06/10] repair: use a listhead for the dotdot list
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 25 Feb 2014 12:03:32 -0800
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1393223369-4696-7-git-send-email-david@xxxxxxxxxxxxx>
References: <1393223369-4696-1-git-send-email-david@xxxxxxxxxxxxx> <1393223369-4696-7-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Feb 24, 2014 at 05:29:25PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Cleanup suggested by Christoph Hellwig - removes another open coded
> list implementation.

Looks good.  Question for both the old and new code:  any good reason to
do the dotdot updates LIFO?  If yes it might be worth adding a comment
about that fact.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>