[Top] [All Lists]

Re: [PATCH] xfs_metadump: include F in getopts string

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfs_metadump: include F in getopts string
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Tue, 25 Feb 2014 11:36:11 -0600
Cc: xfs-oss <xfs@xxxxxxxxxxx>, Boris Ranto <branto@xxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <530CC371.8030005@xxxxxxxxxx>
References: <530CC371.8030005@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 02/25/14 10:23, Eric Sandeen wrote:
I added an F case, but didn't add it to the bash
getopts string last go-round.

/usr/sbin/xfs_metadump: illegal option -- F

I sure thought I tested this, I'm not sure how it got lost.

Reported-by: Boris Ranto<branto@xxxxxxxxxx>
Signed-off-by: Eric Sandeen<sandeen@xxxxxxxxxx>

diff --git a/db/xfs_metadump.sh b/db/xfs_metadump.sh
index 7ce7a6d..71f579d 100755
--- a/db/xfs_metadump.sh
+++ b/db/xfs_metadump.sh
@@ -7,7 +7,7 @@ OPTS=" "
  DBOPTS=" "
  USAGE="Usage: xfs_metadump [-efFogwV] [-m max_extents] [-l logdev] source 

-while getopts "efgl:m:owV" c
+while getopts "efgl:m:owFV" c
        case $c in
        e)      OPTS=$OPTS"-e ";;

Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>