xfs
[Top] [All Lists]

Re: [PATCH 10/10] repair: BMBT prefetch needs to be CRC aware

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 10/10] repair: BMBT prefetch needs to be CRC aware
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 25 Feb 2014 09:25:18 -0800
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1393223369-4696-11-git-send-email-david@xxxxxxxxxxxxx>
References: <1393223369-4696-1-git-send-email-david@xxxxxxxxxxxxx> <1393223369-4696-11-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
>       /*
>        * do some validation on the block contents
>        */
> -     if ((be32_to_cpu(block->bb_magic) != XFS_BMAP_MAGIC) ||
> +     if ((block->bb_magic != cpu_to_be32(XFS_BMAP_MAGIC) &&
> +          block->bb_magic != cpu_to_be32(XFS_BMAP_CRC_MAGIC)) ||
>                       (be16_to_cpu(block->bb_level) != level))

Seems like this should be factored into a well-documented helper
function.

<Prev in Thread] Current Thread [Next in Thread>