xfs
[Top] [All Lists]

Re: [PATCH] xfstests: fix 300.out

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: fix 300.out
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 24 Feb 2014 16:31:02 +1100
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <53079F51.2050406@xxxxxxxxxx>
References: <53079F51.2050406@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Feb 21, 2014 at 12:47:45PM -0600, Eric Sandeen wrote:
> This test was written before a solution was in place, I think,
> and so the expected output wasn't well tested.
> 
> The test does a loop of sparse writes from 6 to 0, but the
> .out file expects 6 (not 7) extents.  Fix it.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> 
> diff --git a/tests/xfs/300.out b/tests/xfs/300.out
> index ac03557..29ed771 100644
> --- a/tests/xfs/300.out
> +++ b/tests/xfs/300.out
> @@ -1,3 +1,3 @@
>  QA output created by 300
>  SCRATCH_MNT/300.test
> -extents before:6 after:1 DONE SCRATCH_MNT/300.test
> +extents before:7 after:1 DONE SCRATCH_MNT/300.test

Looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>