xfs
[Top] [All Lists]

Re: [PATCH] xfstest generic/280: use waidpid instead of ugly sleep

To: Dmitry Monakhov <dmonakhov@xxxxxxxxxx>
Subject: Re: [PATCH] xfstest generic/280: use waidpid instead of ugly sleep
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 24 Feb 2014 16:28:30 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1392972948-2463-1-git-send-email-dmonakhov@xxxxxxxxxx>
References: <1392972948-2463-1-git-send-email-dmonakhov@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Feb 21, 2014 at 12:55:48PM +0400, Dmitry Monakhov wrote:
> 
> Signed-off-by: Dmitry Monakhov <dmonakhov@xxxxxxxxxx>
> ---
>  tests/generic/280 |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/tests/generic/280 b/tests/generic/280
> index 815a2c5..7a2d1d0 100755
> --- a/tests/generic/280
> +++ b/tests/generic/280
> @@ -61,9 +61,10 @@ quotacheck -u -g $SCRATCH_MNT 2>/dev/null
>  quotaon $SCRATCH_MNT 2>/dev/null
>  xfs_freeze -f $SCRATCH_MNT
>  setquota -u root 1 2 3 4 $SCRATCH_MNT &
> +pid=$!
>  sleep 1
>  xfs_freeze -u $SCRATCH_MNT
> -sleep 1
> +wait $pid
>  umount $SCRATCH_DEV

Looks fine.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>