xfs
[Top] [All Lists]

Re: [PATCH] xfstests: add test btrfs/042 for btrfs incremental send

To: Filipe David Borba Manana <fdmanana@xxxxxxxxx>
Subject: Re: [PATCH] xfstests: add test btrfs/042 for btrfs incremental send
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 24 Feb 2014 16:28:02 +1100
Cc: xfs@xxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1392940976-1790-1-git-send-email-fdmanana@xxxxxxxxx>
References: <1392940976-1790-1-git-send-email-fdmanana@xxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Feb 21, 2014 at 12:02:56AM +0000, Filipe David Borba Manana wrote:
> Regression test for a btrfs incremental send issue where invalid paths for
> utimes, chown and chmod operations were sent to the send stream, causing
> btrfs receive to fail.
> 
> If a directory had a move/rename operation delayed, and none of its parent
> directories, except for the immediate one, had delayed move/rename operations,
> after processing the directory's references, the incremental send code would
> issue invalid paths for utimes, chown and chmod operations.
> 
> This issue is fixed by the following linux kernel btrfs patch:
> 
>    Btrfs: fix send issuing outdated paths for utimes, chown and chmod
> 
> Signed-off-by: Filipe David Borba Manana <fdmanana@xxxxxxxxx>
....
> +FSSUM_PROG=$here/src/fssum
> +[ -x $FSSUM_PROG ] || _notrun "fssum not built"

Helper...

.....
> +_scratch_unmount
> +_check_btrfs_filesystem $SCRATCH_DEV

And _check_scratch_fs....

> +_scratch_mkfs >/dev/null 2>&1
> +_scratch_mount
> +
> +_run_btrfs_util_prog receive $SCRATCH_MNT -f $tmp/1.snap
> +run_check $FSSUM_PROG -r $tmp/1.fssum $SCRATCH_MNT/mysnap1 2>> $seqres.full
> +
> +_run_btrfs_util_prog receive $SCRATCH_MNT -f $tmp/2.snap
> +run_check $FSSUM_PROG -r $tmp/2.fssum $SCRATCH_MNT/mysnap2 2>> $seqres.full

And the redirection....

I'm happy to see you write your tests consistently, Filipe :)

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>