xfs
[Top] [All Lists]

Re: [PATCH] xfs_io: add support for flink

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs_io: add support for flink
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 24 Feb 2014 08:06:17 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140221004933.GA9445@xxxxxxxxxxxxx>
References: <20140220220000.GA17541@xxxxxxxxxxxxx> <20140221004933.GA9445@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Feb 20, 2014 at 04:49:33PM -0800, Christoph Hellwig wrote:
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
.....
> +static cmdinfo_t flink_cmd;
> +
> +static void
> +flink_help(void)
> +{
> +     printf(_(
> +"\n"
> +"link the open file descriptor into the filesystem\n"
> +"\n"
> +"\n"));
> +}

"link the open file descriptor to the supplied filename\n"

?

> +void
> +flink_init(void)
> +{
> +     flink_cmd.name = "flink";
> +     flink_cmd.cfunc = flink_f;
> +     flink_cmd.argmin = 1;
> +     flink_cmd.argmax = 1;
> +     flink_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK;
> +     flink_cmd.args = _("filename");
> +     flink_cmd.oneline =
> +             _("link the open file descriptor into the filesystem");
> +     flink_cmd.help = flink_help;
> +
> +     add_command(&flink_cmd);
> +}
> diff --git a/man/man8/xfs_io.8 b/man/man8/xfs_io.8
> index 7a92ff6..7d0c792 100644
> --- a/man/man8/xfs_io.8
> +++ b/man/man8/xfs_io.8
> @@ -638,6 +638,9 @@ Only available in expert mode and requires privileges.
>  Undo the effects of a filesystem freeze operation.
>  Only available in expert mode and requires privileges.
>  .TP
> +.B flink             
> +Link the currently open file descriptor into the filesystem namespace.
> +.TP

And that needs to indicate that a filename needs to be provided,
too.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>